feat(agent): gzip wasm uploads over 25MB and persist encoding metadata#377
Closed
feat(agent): gzip wasm uploads over 25MB and persist encoding metadata#377
Conversation
StashBank
approved these changes
Mar 2, 2026
| hash, | ||
| size: buffer.length, | ||
| buffer: buffer, | ||
| ...(contentEncoding ? { contentEncoding } : {}), |
Member
There was a problem hiding this comment.
Suggested change
| ...(contentEncoding ? { contentEncoding } : {}), | |
| contentEncoding, |
simpler to read
arthurfiorette
requested changes
Mar 2, 2026
| extname, | ||
| hash: asset.hash, | ||
| size, | ||
| ...(contentEncoding ? { contentEncoding } : {}), |
Member
There was a problem hiding this comment.
Suggested change
| ...(contentEncoding ? { contentEncoding } : {}), | |
| contentEncoding, |
simpler to read
| * path and extension for runtime lookup. | ||
| */ | ||
| export function compressLargeAssets(assetsMap: ZeBuildAssetsMap): ZeBuildAssetsMap { | ||
| return Object.values(assetsMap).reduce((memo, asset) => { |
Member
There was a problem hiding this comment.
Use https://nodejs.org/api/zlib.html brotli by default, should get us smaller file sizes.
Also, Im +1 on compressing everything by default.
| */ | ||
| export function compressLargeAssets(assetsMap: ZeBuildAssetsMap): ZeBuildAssetsMap { | ||
| return Object.values(assetsMap).reduce((memo, asset) => { | ||
| if (!shouldCompressAsset(asset.size, asset.contentEncoding)) { |
Member
There was a problem hiding this comment.
to prevent double encoding, maybe we should check if the filename doesn't end with .zip .gz or .br?
|
|
||
| const buffer = | ||
| typeof asset.buffer === 'string' ? Buffer.from(asset.buffer) : asset.buffer; | ||
| const compressed = gzipSync(buffer, { level: 9 }); |
Member
There was a problem hiding this comment.
use zlib.brotliCompress(buffer[, options], callback) (async api) to prevent it from blocking the whole build process while zip assets.
Member
Author
|
Will pick up in the future. Not needed right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification