panel : mixer : rename wp-mixer to mixer#439
Merged
Merged
Conversation
it didn’t really make sense to link the name to the sound server it uses, adding confusion for lay users and tying the features to the server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it didn’t really make sense to start with to link the name to the sound server it uses, adding confusion for lay users and tying the features to the server used, plain volume widget doesn’t do that, and one might want to port mixer to pulseaudio and volume to wireplumber (or whatever else).
The disclaimer/explanation in the example ini file and the wiki should be enough.
Better to change now, while there are still 0 to 2 users, than further down the line.