chore : clean up casts of WfOptions#431
Open
AKArien wants to merge 1 commit into
Open
Conversation
Member
I do agree that this makes the code aesthetically cleaner, at least. |
AKArien
force-pushed
the
casts-cleanup
branch
2 times, most recently
from
bea754d to
90e4ed8
Compare
The preffered way going forward is to let it be implicitely cast, and if impossible use .value() instead of explicitely casting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As stated in chatrooms, the preffered way going forward is to let it be implicetely cast, and if impossible use .value() instead of explicitely casting
Maybe we should add a contributing section to the wiki that mentions it