Skip to content

panel: fix menu focus #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trigg wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −12
Open

panel: fix menu focus #430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions src/util/wf-autohide-window.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,18 +607,15 @@ void WayfireAutohidingWindow::set_active_popover(WayfireMenuButton& button)

const bool should_grab_focus = this->active_button->is_keyboard_interactive();

/*
* if (should_grab_focus)
* {
* // First, set exclusive mode to grab input
* gtk_layer_set_keyboard_mode(this->gobj(), GTK_LAYER_SHELL_KEYBOARD_MODE_EXCLUSIVE);
* wl_surface_commit(get_wl_surface());
*
* // Next, allow releasing of focus when clicking outside of the panel
* gtk_layer_set_keyboard_mode(this->gobj(), GTK_LAYER_SHELL_KEYBOARD_MODE_ON_DEMAND);
* }
*/
// TODO come back for intentional focus steal
if (should_grab_focus)
{
// First, set exclusive mode to grab input
gtk_layer_set_keyboard_mode(this->gobj(), GTK_LAYER_SHELL_KEYBOARD_MODE_EXCLUSIVE);
wl_surface_commit(get_wl_surface());

// Next, allow releasing of focus when clicking outside of the panel
gtk_layer_set_keyboard_mode(this->gobj(), GTK_LAYER_SHELL_KEYBOARD_MODE_ON_DEMAND);
}

this->active_button->set_has_focus(should_grab_focus);
schedule_show(0);
Expand Down
Loading