support arc testnet#163
Open
koo-virtuals wants to merge 4 commits into
Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a6e2682. Configure here.
| arc_testnet: { | ||
| url: | ||
| process.env.ARC_TESTNET_RPC_URL || | ||
| "https://rpc.arc-testnet.network", |
There was a problem hiding this comment.
Wrong Arc testnet RPC default
High Severity
The arc_testnet configuration's default RPC URL (https://rpc.arc-testnet.network) differs from Arc's documented testnet endpoint (https://rpc.testnet.arc.network). Without ARC_TESTNET_RPC_URL set, Hardhat may connect to the wrong network or fail to connect, impacting deploys and scripts.
Reviewed by Cursor Bugbot for commit a6e2682. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Records on-chain proxy deployments for bonding/tax/factory contracts and extends deploy tooling to new chains; no contract source changes in the diff, but wrong manifest or network selection could affect upgrades/ops.
Overview
Adds Arc Network (testnet chain
5042002, mainnet5042) to Hardhat: dedicated RPC env vars (ARC_*_RPC_URL, no genericRPC_URLfallback), and Blockscout-style explorer entries onhardhat.config.jsfor contract verification.Checks in OpenZeppelin upgrade manifests for Arc (
unknown-5042002.json) and BSC testnet (bsc-testnet.json) with transparent proxy addresses, deployment tx hashes, and storage layouts for launchpad/tax/persona contracts (BondingV5,AgentFactoryV7,AgentTaxV2, etc.).Wires launchpadv5 ops to Arc:
run_local_deploy.shnetwork switches (mainnet deploy warning),arc_testnetin the Uniswap V2 testnet liquidity path,handle_buy_sell.tsusage + default agent token, and smaller default liquidity/buy amounts in helper scripts. Base Sepolia default token inhandle_buy_sellis updated to a different address.Reviewed by Cursor Bugbot for commit a6e2682. Bugbot is set up for automated code reviews on this repo. Configure here.