keybindings: Add conditional when support to remapped commands#9968
Open
sim590 wants to merge 1 commit intoVSCodeVim:masterfrom
Open
keybindings: Add conditional when support to remapped commands#9968sim590 wants to merge 1 commit intoVSCodeVim:masterfrom
sim590 wants to merge 1 commit intoVSCodeVim:masterfrom
Conversation
Allow remapped command entries to declare a when clause evaluated against VSCodeVim-owned contexts, and publish vim.isTextDiffEditor to support diff-aware remaps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow remapped command entries to declare a when clause evaluated against VSCodeVim-owned contexts, and publish
vim.isTextDiffEditorto support diff-aware remaps.What this PR does / why we need it
Partially addresses #1372 and #2030.
This PR adds when-clause support for remapped command entries, but scopes that support to contexts owned and published by VSCodeVim itself.
It also introduces
vim.isTextDiffEditor, which makes it possible to write diff-aware remaps such as invoking compare editor navigation only when the active editor is a text diff editor.This does not fully implement arbitrary VS Code when-clause support. Based on the current VS Code extension API, I could not find a reliable way for VSCodeVim to evaluate general workbench context keys from remap definitions, so this PR keeps the feature within the set of contexts controlled by VSCodeVim.