You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please complete all fields. PRs will not be merged if any fields are incomplete. Be respectful, and keep in mind that it may take some time for your PR to be reviewed.
Bear in mind refactors are up to the developers and not it's contributors after all we are the ones giving support when needed. if they are big changes I suggest you to release it under your name instead.
Type of change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
Motive for This Pull Request
This pull request adds prepared shared data tables for animals, peds, and vehicles.
Provide a brief explanation of why these changes are being proposed and what they aim to achieve.
This PR prepares shared/data/animals.lua, shared/data/peds.lua, and shared/data/vehicles.lua so they can be imported directly through the existing import system.
Explain the necessity of these changes and how they will impact the framework or its users.
These changes provide ready-to-use shared data for model lookup. The data is structured for direct use in resources, with model-based keys and source hash values kept in the hash field.
Please describe the tests you have conducted to verify your changes. Provide instructions so we can reproduce these tests. Also, list any relevant details for your test configuration.
Tested with latest vorp scripts
Tested with latest artifacts
Notes if any
The data was prepared from femga/rdr3_discoveries and grouped heuristically for animals, peds, and vehicles. I could not test every entry, but the tests I ran worked well.
I tried to add this but then I started thinking and it doesnt make sense having it here, because all that this does is giving us a string model which is not usefull for anything besides debug and a hex hash which again isnt userfull for anything
I dont see in any instance where this would be usefull to have.
so I left it until I find a good reason to have it, but so far I haven't found any xD
Does anyone think this can be usefull ? and in what scenario?
I tried to add this but then I started thinking and it doesnt make sense having it here, because all that this does is giving us a string model which is not usefull for anything besides debug and a hex hash which again isnt userfull for anything
I dont see in any instance where this would be usefull to have.
so I left it until I find a good reason to have it, but so far I haven't found any xD
Does anyone think this can be usefull ? and in what scenario?
I thought the same when I made the PR, but for example, for ped menus to list existing peds, I think it could be quite useful.
Maybe we could add an extra label ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request template
Important
Please complete all fields. PRs will not be merged if any fields are incomplete. Be respectful, and keep in mind that it may take some time for your PR to be reviewed.
Bear in mind refactors are up to the developers and not it's contributors after all we are the ones giving support when needed. if they are big changes I suggest you to release it under your name instead.
Type of change
Motive for This Pull Request
This pull request adds prepared shared data tables for animals, peds, and vehicles.
Provide a brief explanation of why these changes are being proposed and what they aim to achieve.
This PR prepares
shared/data/animals.lua,shared/data/peds.lua, andshared/data/vehicles.luaso they can be imported directly through the existing import system.Explain the necessity of these changes and how they will impact the framework or its users.
These changes provide ready-to-use shared data for model lookup. The data is structured for direct use in resources, with model-based keys and source hash values kept in the
hashfield.Please describe the tests you have conducted to verify your changes. Provide instructions so we can reproduce these tests. Also, list any relevant details for your test configuration.
Notes if any
The data was prepared from femga/rdr3_discoveries and grouped heuristically for animals, peds, and vehicles. I could not test every entry, but the tests I ran worked well.