Fix hidden search results#1731
Conversation
|
@Saira-A is attempting to deploy a commit to the Universal Viewer Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| padding: 0; | ||
| max-height: 300px; | ||
| overflow: hidden auto; | ||
| z-index: 15; |
There was a problem hiding this comment.
Thanks, @Saira-A! Just curious where the 15 value comes from. Doing a search through the code, for example, I see some annotations with a z-index of 20. Is it possible there could be conflicts there?
(In any case, I'm happy to approve and merge this if you're confident it's an improvement -- but just want to be sure there aren't other edge cases we're missing, since it's hard to test every scenario).
There was a problem hiding this comment.
@demiankatz I went with 15 because it was the lowest value that worked, but can increase it to be safe - could do 25 to make sure it stays in front of annotations?
There was a problem hiding this comment.
Yeah, 25 sounds like it might be worth a try. We'd just want to check the various dialog boxes and make sure everything stacks in a logical way. Let me know if you need help with that part!
There was a problem hiding this comment.
Thanks @demiankatz - looks ok to me but an extra pair of eyes wouldn't hurt :)
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @Saira-A, I can't find a way to break it. :-)
2 participants
This fixes the issue found in #1726 where search results hide underneath the image by adding a z-index to the autocomplete function