fix(security): harden temp-dir handling against symlink/env-override#676
Merged
Conversation
…risks - learn.sh: replace predictable /tmp/bashunit_learn_$$ with mktemp -d - coverage.sh: replace $$-$RANDOM path with mktemp -d - parallel.sh: cleanup() refuses to rm -rf a TEMP_DIR_PARALLEL_TEST_SUITE that is not under */bashunit/parallel/* Adds regression test asserting cleanup leaves an out-of-tree path intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/learn.sh: replace predictable/tmp/bashunit_learn_$$withmktemp -d, eliminating PID-based symlink races in shared/tmpsrc/coverage.sh: replace$$-$RANDOMdirectory naming withmktemp -dfor the same reason and to drop the (low but real) collision risksrc/parallel.sh:bashunit::parallel::cleanupnow refuses torm -rfaTEMP_DIR_PARALLEL_TEST_SUITEwhose path is not under*/bashunit/parallel/*— guards against accidental wipes when the env var is overriddenBackground
Came out of a security/bug audit of
src/. Eval-based findings (assert_duration,bashunit assert "<cmd>",--debug FILE) were verified as intentional CLI APIs, not vulnerabilities — only the temp-dir issues were real. No public API changes.