perf(runner): collapse detect_runtime_error scan#669
Merged
Conversation
Replace 23-iteration for-loop with single case glob alternation. Same behavior, no per-iteration case setup. Adds direct unit tests covering empty input, no-error path, several error strings, and newline stripping. Closes #668
Chemaclass
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bashunit::runner::detect_runtime_errorwith a singlecaseglob alternation.casesetup.tests/unit/runner_test.shcovering empty input, no-error path, key error strings, and newline stripping.Test plan
./bashunit tests/unit/green (821 passed)./bashunit --parallel tests/greenmake sa(ShellCheck) cleanmake lint(editorconfig) cleanCloses #668