refactor(runner): extract encoded field decoder#657
Merged
Chemaclass merged 1 commit intomainfrom May 3, 2026
Merged
Conversation
Replace three near-duplicate `${result##*##KEY=}` parsing blocks in
`bashunit::runner::run_test` with a single
`bashunit::runner::extract_encoded_field` helper that takes the key
name and returns an empty string when the marker is absent. Bash 3.0+
compatible (`case`/`esac`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Final iter of the
run_testslim-down. Three encoded fields (TEST_TITLE,TEST_HOOK_FAILURE,TEST_HOOK_MESSAGE) were each decoded with a near-identical pair of parameter expansions, andTEST_HOOK_FAILUREhad to compare against the full result to detect "no key present".💡 Changes
bashunit::runner::extract_encoded_field <result> <key>— uses acasematch so the absent-key case returns an empty string explicitlycase/esac, no[[ ]], no associative arrays)