-
-
Notifications
You must be signed in to change notification settings - Fork 851
fixed undefined behavior #1864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
fixed undefined behavior #1864
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
766c264
fix: replace withdrawn SQLite 3.52.0 with stable 3.51.3
MatheusBaldi 7f4d920
forked TryGhost/node-sqlite3 branch master to gms1/node-sqlite3 branc…
gms1 40acd70
git ignore
gms1 c45aeb4
changed npm package to @homeofthings scope
gms1 32eca27
npm publishing via ci and trusted publisher
gms1 7d4c26b
fixed badges
gms1 67e27dd
fixed badges
gms1 35f9413
fixed badges
gms1 a3e2554
Merge branch 'pr-1858'
gms1 98f3a53
fixed npm version badge
gms1 2139e8e
fixed changelog
gms1 008327d
6.1.0
gms1 dc302eb
ci fixed
gms1 7a1e985
6.2.0
gms1 38c9d63
Revert "6.2.0"
gms1 c131bea
Revert "6.1.0"
gms1 11a2f64
6.1.0
gms1 5ed15f1
ci: updated microsoft/setup-msbuild to version 2
gms1 6153915
fixed ci version check
gms1 c17caad
linting and benchmark
gms1 9e7b42c
enforce linting via ci workflow
gms1 ad4be33
use the lockfile inside ci workflow
gms1 08ed986
refactored benchmarks
gms1 e8a03a3
improved documentation
gms1 70e8673
fixed undefined behavior
gms1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| # EditorConfig is awesome: https://EditorConfig.org | ||
|
|
||
| # Top-most EditorConfig file | ||
| root = true | ||
|
|
||
| # Unix-style newlines with a newline ending every file | ||
| [*] | ||
| indent_style = space | ||
| indent_size = 2 | ||
| end_of_line = lf | ||
| charset = utf-8 | ||
| trim_trailing_whitespace = true | ||
| insert_final_newline = true | ||
|
|
||
| # Matches multiple files with the same settings | ||
| [*.js] | ||
| indent_size = 2 | ||
|
|
||
| [*.json] | ||
| indent_size = 2 | ||
|
|
||
| [*.yml] | ||
| indent_size = 2 | ||
|
|
||
| [*.md] | ||
| trim_trailing_whitespace = false | ||
| indent_size = 2 | ||
|
|
||
| [*.sql] | ||
| indent_size = 2 | ||
|
|
||
| # C/C++ files | ||
| [*.cc] | ||
| indent_size = 2 | ||
| indent_style = tab | ||
| max_line_length = 100 | ||
|
|
||
| [*.h] | ||
| indent_size = 2 | ||
| indent_style = tab | ||
| max_line_length = 100 | ||
|
|
||
| # Makefile and GYP files use tabs | ||
| [{Makefile,*.gyp}] | ||
| indent_style = tab | ||
|
|
||
| # Dockerfiles | ||
| [Dockerfile] | ||
| indent_size = 2 | ||
|
|
||
| # YAML files | ||
| [*.yaml] | ||
| indent_size = 2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,14 @@ | ||
| module.exports = { | ||
| "extends": "eslint:recommended", | ||
| "env": { | ||
| "es2017": true, | ||
| "es2020": true, | ||
| "node": true | ||
| }, | ||
| "rules": { | ||
| "indent": ["error", 4], | ||
| "linebreak-style": ["error", "unix"], | ||
| "semi": ["error", "always"], | ||
| "no-cond-assign": ["error", "always"] | ||
| "no-cond-assign": ["error", "always"], | ||
| "no-inner-declarations": "off" | ||
| } | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # Mark SQLite database files as binary to prevent line ending conversions | ||
| *.db binary | ||
| *.sqlite binary | ||
| *.sqlite3 binary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| blank_issues_enabled: false | ||
| contact_links: | ||
| - name: 📖 API documentation | ||
| url: https://github.com/TryGhost/node-sqlite3/wiki/API | ||
| url: https://github.com/gms1/node-sqlite3/wiki/API | ||
| about: Documentation for the `node-sqlite3` API |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,3 +29,6 @@ setup.sh | |
| *.tgz | ||
| package-lock.json | ||
| prebuilds | ||
| .vscode | ||
| .clinerules | ||
| .roomodes | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI publish job likely missing npm authentication configuration
Medium Severity
The
publish-npmjob usesactions/setup-nodewithregistry-url, which creates an.npmrcreferencing${NODE_AUTH_TOKEN}, but noNODE_AUTH_TOKENenvironment variable is provided on thenpm publishstep. Whileid-token: writesuggests OIDC trusted publishing was intended, theactions/setup-noderegistry-urloption is known to interfere with OIDC by injecting an unresolved token reference. Thenpm publishcall likely needs either a--provenanceflag orNODE_AUTH_TOKENset explicitly.