cove: add check for large number of XLSX sheet rows#174
Merged
Conversation
This commit fixes an issue where XLSX spreadsheets with a malformed number of rows generate very large unflattened JSON files. The fix simply checks for an excessive number of rows before passing off to cove/flattentool. The number of rows considered excessive is controllable through the MAX_XLSX_ROWS environment variable and set by default to 50000.
Pull Request Test Coverage Report for Build 23556356187Details
💛 - Coveralls |
BibianaC
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where XLSX spreadsheets with a malformed number of rows generate very large unflattened JSON files. This fix only applies to files uploaded to the web interface of the DQT not to the command line tools, such as
cove_checks.py. It also doesn't make any changes tolib360dataquality, for example, as used by thedatagetter, since thedatagetterfirst unflattens and then validates. However, we could implement a similar check/fix in thedatagetter.The maximum number of rows is controllable with an environment variable. The default has been set to 50000 by sampling existing files in the registry and adding a substantial margin.
Note: A more comprehensive and underlying fix would be to add this as an optional check to flattentool and then enable that optional check across the various tools.