Fix(finalhandler): prevent setting status code after headers sent#6
Open
PlumBlossomMaid wants to merge 1 commit intoTRIGONIM:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a client disconnects prematurely (e.g., rapid page refresh),
finalhandlermay attempt to set a status code after response headers have already been sent. This triggers an assertion in pegasus:Fix #5
Root Cause
finalhandler.lua'ssend()function does not check whetherres.pg_res._headersSendedis true before callingres:status().There is already a check for the 404 case at line 80:
However, this does not cover cases where
erris present (e.g., 500 errors).Solution
Added a unified check at the beginning of
send():This extends the protection to all error cases and prevents the pegasus assertion entirely.
Testing
Environment