Fix repeated seeks during playback on Safari#142
Merged
MattiasBuelens merged 6 commits intomainfrom Apr 22, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 4a9fc21 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
MattiasBuelens
force-pushed
the
bugfix/repeated-seeks-during-playback
branch
from
c77faf1 to
4abe40d
Compare
MattiasBuelens
force-pushed
the
bugfix/repeated-seeks-during-playback
branch
from
4abe40d to
4a9fc21
Compare
rbnbtns
approved these changes
Apr 22, 2026
ceyhun-o
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS and iOS Safari, the player was triggering repeated seeks during playback, leading to very noticeable stuttering.
The problem was that
TimeRange._updateFromPlayerwould setthis.value, which would always callthis.handleInput()and as such trigger a seek on the player. This is a regression in version 2.0.0: in 1.x,_updateFromPlayerwould not go throughthis.valueand would instead set the new value directly on the<input type=range>.I fixed it by reviving some lost logic from 1.x: we now go through the new
this.rawValueinstead, which deliberately does not callhandleInput().