Conversation
MattiasBuelens
approved these changes
Apr 23, 2026
Contributor
MattiasBuelens
left a comment
MattiasBuelens
left a comment
There was a problem hiding this comment.
LGTM.
We probably need a better way to keep our CocoaPods and SPM dependencies in sync... 🤔 @therama Any ideas?
therama
approved these changes
Apr 23, 2026
Contributor
We could make a new step in the validation workflow to make sure version values are matched in the Package.swift and the respective connector .podspec files. Tricky part will be how to map the operands. If it was exact match things would be simple, but SPM/Cocoapods have different allowed values/perimeters for version specification. |
Contributor
Author
|
Merging this for now. We will follow up how to map the versions on another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: