-
Notifications
You must be signed in to change notification settings - Fork 3
Build and run whatever tests we have in the pipeline #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
06504e7
swift compiler ver 5.3 does not support .iOS(.v15)
Yousif-CS 2f8a30e
add sideloaded subtitles test target
Yousif-CS c68d928
introduce smoke test pipeline
Yousif-CS 53e2005
fix failing test compilation for uplynk
Yousif-CS a4c39c3
rename pipeline
Yousif-CS d53b6b1
Revert "add sideloaded subtitles test target"
Yousif-CS adafc85
remove unnecessary run-name
Yousif-CS f2cce42
bump macos & xcode to 26
Yousif-CS 3a70de5
use newer simulator version due to bump
Yousif-CS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| name: Build and Test (PR) | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, reopened] | ||
| push: | ||
| branches: [main] | ||
| workflow_dispatch: | ||
|
|
||
| concurrency: | ||
| group: build-and-test-${{ github.head_ref || github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| build-and-test: | ||
| runs-on: macos-26 | ||
|
|
||
| env: | ||
| DESTINATION: 'generic/platform=iOS Simulator' | ||
| # Connectors to build — Yospace excluded (requires proprietary YOAdManagement SDK) | ||
| BUILD_SCHEMES: >- | ||
| THEOplayerConnectorUtilities | ||
| THEOplayerConnectorConviva | ||
| THEOplayerConnectorNielsen | ||
| THEOplayerConnectorSideloadedSubtitle | ||
| THEOplayerConnectorUplynk | ||
| # Test schemes to run | ||
| TEST_SCHEMES: >- | ||
| THEOplayerConnectorUplynkTests | ||
|
|
||
| steps: | ||
| - uses: maxim-lobanov/setup-xcode@v1 | ||
| with: | ||
| xcode-version: '26.3.0' | ||
|
|
||
| - name: Log environment | ||
| run: | | ||
| echo "macOS:" && sw_vers | ||
| echo "Xcode:" && xcodebuild -version | ||
| echo "Swift:" && swift --version | ||
|
|
||
| - name: Check out repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Resolve SPM dependencies | ||
| run: | | ||
| xcodebuild -resolvePackageDependencies \ | ||
| -scheme THEOplayerConnectorUtilities \ | ||
| -destination "$DESTINATION" | ||
|
|
||
| - name: Build connectors | ||
| run: | | ||
| set -euo pipefail | ||
| for scheme in $BUILD_SCHEMES; do | ||
| echo "----------------------------------------" | ||
| echo "Building: $scheme" | ||
| echo "----------------------------------------" | ||
| xcodebuild build \ | ||
| -scheme "$scheme" \ | ||
| -destination "$DESTINATION" \ | ||
| -skipPackagePluginValidation \ | ||
| | xcpretty | ||
| done | ||
|
|
||
| - name: Run tests | ||
| run: | | ||
| set -euo pipefail | ||
| SIM_DEST='platform=iOS Simulator,name=iPhone 17' | ||
| for scheme in $TEST_SCHEMES; do | ||
| echo "----------------------------------------" | ||
| echo "Testing: $scheme" | ||
| echo "----------------------------------------" | ||
| xcodebuild test \ | ||
| -scheme "$scheme" \ | ||
| -destination "$SIM_DEST" \ | ||
| -skipPackagePluginValidation \ | ||
| | xcpretty | ||
| done | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we resolve only THEOplayerConnectorUtilities dependencies? Is it because it dependens on THEOplayerSDK which the uplynk test also needs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep that's right