Fix 'undefined columns selected' in predict.bcfmodel with data frame covariates (GH 374)#375
Merged
andrewherren merged 2 commits intomainfrom May 1, 2026
Merged
Fix 'undefined columns selected' in predict.bcfmodel with data frame covariates (GH 374)#375andrewherren merged 2 commits intomainfrom
andrewherren merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an R BCF prediction bug unearthed by #374 where covariates are provided as a dataframe (and thus run through the dataframe preprocessor logic) and an internal propensity model is fit. In this case, the order of operations in the
predict.bcfmodelfunction is such that the internal propensity model is called before the preprocessor.The fix is simple -- invert the order of these two operations. We've also added a unit test to trap this case in the future.