fix(discord): sanitize autocomplete choices#830
Open
ugcodrr wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
* Ensure choices with undefined or null values are excluded * Trim choice names and handle empty strings more effectively * Maintain maximum length constraints for choice values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Sentry error where Discord rejects autocomplete responses with
Invalid Form Body | data.choices[n].name - BASE_TYPE_BAD_LENGTH.This sanitizes autocomplete choices at the shared Discord response boundary before replying:
This covers the observed
statuscommand/player search case where a raw whitespace query could be appended as an autocomplete choice.