interpreting server_mode field (to support Valkey 8+ cluster)#3050
Open
wipiano wants to merge 1 commit intoStackExchange:mainfrom
Open
interpreting server_mode field (to support Valkey 8+ cluster)#3050wipiano wants to merge 1 commit intoStackExchange:mainfrom
server_mode field (to support Valkey 8+ cluster)#3050wipiano wants to merge 1 commit intoStackExchange:mainfrom
Conversation
wipiano
changed the title
server_mode field (to support Valkey 8+ cluster)server_mode field (to support Valkey 8+ cluster)
wipiano
force-pushed
the
experimental-valkey-cluster
branch
from
aa15182 to
241da1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Valkey 8, the
redis_modefield in theINFO serverresponse has been renamed toserver_mode.This causes StackExchange.Redis to misidentify a Valkey Cluster as running in standalone mode, resulting in incorrect behavior.
As a current workaround, setting
extended-redis-compatibility yeson the Valkey server side preserves theredis_modefield in theINFO serverresponse. However, this configuration option may be removed in a future version.This change adds support for interpreting the
server_modefield in the same way as theredis_modefield.