Skip to content

fix: harden GitHub Actions workflows#173

Merged
lelia merged 1 commit intomainfrom
fix/zizmor-workflow-security
Mar 25, 2026
Merged

fix: harden GitHub Actions workflows#173
lelia merged 1 commit intomainfrom
fix/zizmor-workflow-security

Conversation

@reberhardt7
Copy link
Contributor

@reberhardt7 reberhardt7 commented Mar 25, 2026

Summary

  • Template injection fixes: Replaced inline ${{ }} expressions in shell run blocks with environment variables in docker-stable.yml and release.yml to prevent script injection attacks
  • Pinned actions to SHA: Pinned all third-party Docker actions in docker-stable.yml to full commit SHAs (checkout, setup-qemu, setup-buildx, login, build-push)
  • Least-privilege permissions: Added top-level permissions blocks with minimal scoping to docker-stable.yml, e2e-test.yml, and version-check.yml
  • Credential hardening: Added persist-credentials: false to all actions/checkout steps across workflows
  • zizmor config: Added .github/zizmor.yml configuration file
  • Minor: Fixed missing newlines at end of docker-stable.yml and release.yml

- Fix template injection vulnerabilities by using environment variables
  instead of inline expressions in shell scripts (docker-stable, release)
- Pin third-party actions to full SHA commits (docker-stable)
- Add top-level permissions blocks with least-privilege scoping
  (docker-stable, e2e-test, version-check)
- Add persist-credentials: false to all checkout steps
- Add zizmor.yml configuration file
- Fix missing newlines at end of files

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@reberhardt7 reberhardt7 requested a review from a team as a code owner March 25, 2026 04:02
@github-actions
Copy link

🚀 Preview package published!

Install with:

pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.2.79.dev3

Docker image: socketdev/cli:pr-173

@lelia lelia self-assigned this Mar 25, 2026
@reberhardt7 reberhardt7 changed the title fix: harden GitHub Actions workflows (zizmor) fix: harden GitHub Actions workflows Mar 25, 2026
@lelia lelia merged commit abe5df3 into main Mar 25, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants