Add CustomResourceConfig proto for shell-command launchers#625
Open
kmontemayor2-sc wants to merge 3 commits intomainfrom
Open
Add CustomResourceConfig proto for shell-command launchers#625kmontemayor2-sc wants to merge 3 commits intomainfrom
CustomResourceConfig proto for shell-command launchers#625kmontemayor2-sc wants to merge 3 commits intomainfrom
Conversation
Introduces a new `oneof` arm on `TrainerResourceConfig` / `InferencerResourceConfig` that lets callers describe a launcher as a shell command + positional args, instead of a fixed-shape Vertex AI / KFP / local resource config. The proto carries no semantics here — the dispatcher is added in a follow-up PR; this commit only ships the message, regenerated bindings, and the wrapper-property update so downstream code can read `wrapper.trainer_config` and get a `CustomResourceConfig` back. The diff includes a long tail of cosmetic Scala changes outside `gigl_resource_config/` because scalapbc regenerates every sibling proto's emitted source whenever any one proto in the same directory changes. Reviewers can scope to `CustomResourceConfig.scala` and the `*ResourceConfig.scala` siblings that gain the new oneof case. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
/all_test |
Contributor
GiGL Automation@ 23:07:46UTC : 🔄 @ 23:14:06UTC : ❌ Workflow failed. |
Contributor
GiGL Automation@ 23:07:46UTC : 🔄 @ 23:09:45UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 23:07:51UTC : 🔄 @ 24:29:53UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 23:07:52UTC : 🔄 @ 23:18:38UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 23:07:53UTC : 🔄 @ 24:30:49UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 23:07:55UTC : 🔄 @ 23:24:00UTC : ✅ Workflow completed successfully. |
svij-sc
approved these changes
May 7, 2026
kmontemayor2-sc
requested review from
mkolodner-sc,
nshah-sc,
xgao4-sc and
yliu2-sc
as code owners
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
CustomResourceConfig is launcher-pluggable — there is no concrete machine spec to validate against (no machine_type, num_workers, GPU config, etc.). The wrapper's trainer_config / inferencer_config properties now return a union that includes CustomResourceConfig (introduced earlier in this PR), but _validate_machine_config does not accept it. Add an isinstance early-return guard at each call site that logs the skip and returns. Shape and backend-compatibility validation for CustomResourceConfig come in a follow-up PR; this commit only makes the existing validation flow type-clean against the widened union. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
kmontemayor2-sc
force-pushed
the
kmonte/custom-resource-config-pr1-proto
branch
from
8c727e3 to
0425547
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new
oneofarm onTrainerResourceConfig/InferencerResourceConfigthat lets callers describe a launcher as a shell command + positional args, instead of a fixed-shape Vertex AI / KFP / local resource config. The proto carries no semantics here — the dispatcher is added in a follow-up PR; this commit only ships the message, regenerated bindings, and the wrapper-property update so downstream code can readwrapper.trainer_configand get aCustomResourceConfigback.The diff includes a long tail of cosmetic Scala changes outside
gigl_resource_config/because scalapbc regenerates every sibling proto's emitted source whenever any one proto in the same directory changes. Reviewers can scope toCustomResourceConfig.scalaand the*ResourceConfig.scalasiblings that gain the new oneof case.Scope of work done
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO