validation: enforce TensorBoard fields are set together#620
Draft
kmontemayor2-sc wants to merge 2 commits intomainfrom
Draft
validation: enforce TensorBoard fields are set together#620kmontemayor2-sc wants to merge 2 commits intomainfrom
kmontemayor2-sc wants to merge 2 commits intomainfrom
Conversation
Adds two optional fields on ``VertexAiResourceConfig`` for opting into Vertex AI TensorBoard. ``tensorboard_resource_name`` points at an existing ``Tensorboard`` resource; ``tensorboard_experiment_name`` is the user-chosen ``TensorboardExperiment`` ID under that resource — multiple jobs sharing this name surface as comparable runs on the same TB page. The fields must be set together (or both unset). The validation rule is not enforced yet (lands in a follow-up PR); this commit only adds the proto fields and regenerates Python + Scala stubs. Also expands the docstring on ``TrainedModelMetadata.tensorboard_logs_uri`` to document its mapping to ``AIP_TENSORBOARD_LOG_DIR`` via ``CustomJobSpec.baseOutputDirectory``. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds ``check_vertex_ai_trainer_tensorboard_compatibility`` to the ConfigPopulator/DataPreprocessor/SubgraphSampler/SplitGenerator/Trainer start-points. Rule: - ``tensorboard_resource_name`` and ``tensorboard_experiment_name`` on ``VertexAiResourceConfig`` (or ``compute_pool`` of the graph-store variant) must both be set or both unset. Setting only one produces no observable behavior — the chief-rank uploader needs both. - ``tensorboard_experiment_name`` must satisfy the Vertex AI Experiment ID regex (lowercase letters, digits, hyphens; max 128 chars). - ``GbmlConfig.trainer_config.should_log_to_tensorboard=true`` requires both fields to be set. Validation fires before code reads the new proto fields, so existing configs (which set neither field) pass without change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
/all_test |
Contributor
GiGL Automation@ 18:59:03UTC : 🔄 @ 20:10:07UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 18:59:04UTC : 🔄 @ 20:20:30UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 18:59:04UTC : 🔄 @ 19:01:27UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 18:59:10UTC : 🔄 @ 19:07:23UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 18:59:10UTC : 🔄 @ 19:08:11UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 18:59:10UTC : 🔄 @ 20:22:58UTC : ✅ Workflow completed successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
check_vertex_ai_trainer_tensorboard_compatibilityto theConfigPopulator/DataPreprocessor/SubgraphSampler/SplitGenerator/Trainer
start-points. Rule:
tensorboard_resource_nameandtensorboard_experiment_nameonVertexAiResourceConfig(orcompute_poolof the graph-storevariant) must both be set or both unset. Setting only one produces
no observable behavior — the chief-rank uploader needs both.
tensorboard_experiment_namemust satisfy the Vertex AI ExperimentID regex (lowercase letters, digits, hyphens; max 128 chars).
GbmlConfig.trainer_config.should_log_to_tensorboard=truerequiresboth fields to be set.
Validation fires before code reads the new proto fields, so existing
configs (which set neither field) pass without change.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com