proto: add tensorboard_resource_name + tensorboard_experiment_name#618
Draft
kmontemayor2-sc wants to merge 1 commit intomainfrom
Draft
proto: add tensorboard_resource_name + tensorboard_experiment_name#618kmontemayor2-sc wants to merge 1 commit intomainfrom
kmontemayor2-sc wants to merge 1 commit intomainfrom
Conversation
Adds two optional fields on ``VertexAiResourceConfig`` for opting into Vertex AI TensorBoard. ``tensorboard_resource_name`` points at an existing ``Tensorboard`` resource; ``tensorboard_experiment_name`` is the user-chosen ``TensorboardExperiment`` ID under that resource — multiple jobs sharing this name surface as comparable runs on the same TB page. The fields must be set together (or both unset). The validation rule is not enforced yet (lands in a follow-up PR); this commit only adds the proto fields and regenerates Python + Scala stubs. Also expands the docstring on ``TrainedModelMetadata.tensorboard_logs_uri`` to document its mapping to ``AIP_TENSORBOARD_LOG_DIR`` via ``CustomJobSpec.baseOutputDirectory``. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
/all_test |
Contributor
GiGL Automation@ 18:55:04UTC : 🔄 @ 20:21:10UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 18:55:04UTC : 🔄 @ 19:05:07UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 18:55:08UTC : 🔄 @ 20:21:21UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 18:55:08UTC : 🔄 @ 18:57:03UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 18:55:09UTC : 🔄 @ 19:52:37UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 18:55:11UTC : 🔄 @ 19:03:54UTC : ✅ Workflow completed successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two optional fields on
VertexAiResourceConfigfor opting into Vertex AI TensorBoard.tensorboard_resource_namepoints at an existingTensorboardresource;tensorboard_experiment_nameis the user-chosenTensorboardExperimentID under that resource — multiple jobs sharing this name surface as comparable runs on the same TB page.The fields must be set together (or both unset). The validation rule is not enforced yet (lands in a follow-up PR); this commit only adds the proto fields and regenerates Python + Scala stubs.
Also expands the docstring on
TrainedModelMetadata.tensorboard_logs_urito document its mapping toAIP_TENSORBOARD_LOG_DIRviaCustomJobSpec.baseOutputDirectory.Scope of work done
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO