Add 'local' launch script for graph store mode - so we can simulate the cluster on dev boxes#587
Merged
kmontemayor2-sc merged 5 commits intomainfrom May 7, 2026
Merged
Conversation
Collaborator
mkolodner-sc
left a comment
mkolodner-sc
left a comment
There was a problem hiding this comment.
Should this go in scripts? Looking our scripts folder currently, the majority of scripts here are to help setup GiGL. This to me feels like something that would be better in an experimental folder since I imagine this is primarily used for testing/debugging -- WDYT?
Collaborator
Author
|
I don't think this belongs in "experimental" as it's not experimental - it's production ready and meant to be used (potentially for experiments). We could put it elsewhere, maybe |
mkolodner-sc
approved these changes
May 6, 2026
svij-sc
approved these changes
May 7, 2026
_build_cluster_spec previously hard-coded :2222 for every entry. The per-entry ports are not consumed at runtime (cluster spec consumers in gigl/distributed/utils/networking.py only read len(...)), but populating them with real free ports makes the manifest representative of what Vertex AI would produce. main() now requests 1 + world_size ports up front: the first becomes MASTER_PORT, the rest are threaded through build_node_processes to populate workerpool0/1/2 entries indexed by global rank. Also rename tests/unit/scripts -> tests/unit/scripts_test and add an __init__.py so 'make unit_test_py' discovers the launcher test without shadowing the top-level scripts/ package. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
kmontemayor2-sc
requested review from
nshah-sc,
xgao4-sc,
yliu2-sc and
zfan3-sc
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
Scope of work done
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO