Draft
Conversation
Each FrameRunner (PhoReal, SurfaceFitter, SurfaceBlanket) had its column schema defined in two places: a static registerSchema() at startup and a duplicate schema_description_t array in run(). The runtime registration was always a no-op since the schema was already registered at startup. This removes the duplicate arrays from run() and replaces the two-arg populateGeoColumns(name, descs) with a new refreshGeoColumns() that only re-discovers geo column roles (time/x/y/z) without doing schema work. Net result: -64 lines, one source of truth per runner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.