Migrate raw pointers to unique_ptr and fix memory/stability issues#38
Open
crayy8 wants to merge 8 commits intoSleuthKitLabs:develop-4.14from
Open
Migrate raw pointers to unique_ptr and fix memory/stability issues#38crayy8 wants to merge 8 commits intoSleuthKitLabs:develop-4.14from
crayy8 wants to merge 8 commits intoSleuthKitLabs:develop-4.14from
Conversation
Member
crayy8
commented
Mar 24, 2026
crayy8
commented
- Replace raw pointer ownership with unique_ptr throughout the library: RegistryByteBuffer, ValueData, RegistryKey, RegistryValue, RegistryHiveFile, RegistryHiveBuffer, Cell, HBIN, REGFHeader, NKRecord, VKRecord, ValueListRecord
- Remove AutoCellPtrList and AutoHBINPtrList RAII wrappers now that unique_ptr handles lifetime automatically
- Add virtual destructor to BinaryBlock to prevent UB when deleting through base class pointer
- Fix integer overflow in ByteBuffer::read() bounds check via uint64_t cast
- Fix dangling pointer in RejistryException::what() by caching result in mutable member
- Fix RegistryHiveFile::getErrorMessage() to handle FormatMessageA failure
- Fix REGFHeader::getHBINs() to std::move unique_ptr into vector
- Refactor Rejistry test program to exercise both RegistryHiveFile and RegistryHiveBuffer through shared processRegistryHive() function
- Replace raw pointer ownership with unique_ptr throughout the library: RegistryByteBuffer, ValueData, RegistryKey, RegistryValue, RegistryHiveFile, RegistryHiveBuffer, Cell, HBIN, REGFHeader, NKRecord, VKRecord, ValueListRecord - Remove AutoCellPtrList and AutoHBINPtrList RAII wrappers now that unique_ptr handles lifetime automatically - Add virtual destructor to BinaryBlock to prevent UB when deleting through base class pointer - Fix integer overflow in ByteBuffer::read() bounds check via uint64_t cast - Fix dangling pointer in RejistryException::what() by caching result in mutable member - Fix RegistryHiveFile::getErrorMessage() to handle FormatMessageA failure - Fix REGFHeader::getHBINs() to std::move unique_ptr into vector - Refactor Rejistry test program to exercise both RegistryHiveFile and RegistryHiveBuffer through shared processRegistryHive() function
APriestman
approved these changes
Mar 24, 2026
- Replace raw pointer typedefs with unique_ptr equivalents across NKRecord, VKRecord, HBIN, SubkeyListRecord, ValueListRecord, RegistryKey, RegistryValue, ValueData, and RegistryHive - Remove AutoNKRecordPtrList and AutoVKRecordPtrList RAII wrappers - Return unique_ptr from getRoot(), getSubkeyList(), getValueList(), getValue(), getSubkeys(), and getValues() throughout the hierarchy - Add bounds check in HBIN::getCells() to prevent over-reading hbin - Delete copy assignment operators on Buffer and Record base classes - Replace NULL with nullptr in HBIN and RegistryByteBuffer
- Remove undocumented MAX_NAME_LENGTH check on class names (no spec limit exists) - Fix class name UTF-16LE decoding via reinterpret_cast - Fix inline QWORD/FILETIME data handling when high bit signals inline storage - Add safeLength clamping for cell-stored QWORD/FILETIME values - Use getSubkeyCount() instead of getSubkeyList()->getListLength() - Remove dead null checks after unique_ptr construction - Remove redundant break in HBIN cell iteration - Remove duplicate processRegistryBuffer pass from test driver - Add comprehensive test hive generator (33 scenarios) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace raw pointer usage and std::auto_ptr with std::unique_ptr throughout RegParser.cpp, RegKey.cpp, and RegVal.cpp. Use .release(), .get(), auto, and range-for loops to adapt to the new ownership semantics. Remove manual delete calls that are now handled by unique_ptr destructors.
Member
Author
|
This now has all of rejistry++ using unqiue pointers so no manual memory management is needed. |
…mprovements - EmptySubkeyList: override getListLength() (returns 0) and shadow getMagic() (returns "") to prevent reading garbage from REGF header when subkey count is zero - SubkeyListRecord: make getListLength() virtual to enable override - Rejistry.cpp test driver: add SEH wrapper to catch stack overflow and other structured exceptions with diagnostic output to both stdout and stderr; add MAX_RECURSION_DEPTH=1000 safety check; cap named lookups at 10 per key to avoid O(n^2) on large subkey lists; add hive summary stats (HBIN/cell/key/value counts, type breakdowns, extremes); condense HBIN/cell output to one line each - Rejistry.vcxproj: increase stack reserve to 4MB across all configs to handle deeply nested hives (500+ levels)
Member
Author
|
@APriestman if you care there is https://basistech.atlassian.net/browse/CT-11222 that has the test scripts I created to test all of this plus the test hives and results of the diff against ct_3.16 tsk branch. Everything looks good. No regressions but a bunch of fixes. It was crashing on 15+ of the hives and some data was not reported in certain scenarios and now we have no crashes I'm not going to remove do not merge label until the CT PR is ready but this can be reviewed when you have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.