Return MethodNotFound (-32601) for unrecognized LSP requests#4040
Open
IgorFroehner wants to merge 1 commit intoShopify:mainfrom
Open
Return MethodNotFound (-32601) for unrecognized LSP requests#4040IgorFroehner wants to merge 1 commit intoShopify:mainfrom
IgorFroehner wants to merge 1 commit intoShopify:mainfrom
Conversation
The process_message case statement had no else clause, so requests for unsupported methods were silently dropped. This caused clients to hang indefinitely waiting for a response. The LSP spec requires servers to respond with error code -32601 for unsupported methods. Fixes Shopify#3981
Author
|
I have signed the CLA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #3981
The
process_messagecase statement had no else clause, so requests for unsupported methods were silently dropped. This caused clients to hang indefinitely waiting for a response. The LSP spec requires servers to respond with error code -32601 for unsupported methods.Implementation
Just answer with Method not found when the message method don't match any of the switch statement branches.
Automated Tests
I added one check to see if the message
RubyLsp::Errorwas sent.Manual Tests
Start the server via bundle exec ruby-lsp and send a request with an unsupported method (e.g. textDocument/nonExistentMethod). Verify the server responds with {"error": {"code": -32601, "message": "Method not found: textDocument/nonExistentMethod"}} instead of silently dropping the request.