Conversation
…n toolset() The toolset() function in agentscope integration was incorrectly calling .to_crewai() instead of .to_agentscope(), returning CrewAI-formatted tools instead of AgentScope-formatted ones. Change-Id: I41758ca6e22173cfc4cc47fa95713c8fb5d992a7 Co-developed-by: Claude <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Fixes the AgentScope integration helper to return AgentScope-formatted tools by calling to_agentscope() instead of mistakenly calling to_crewai(), which previously produced CrewAI-formatted tools.
Changes:
- Update
agentrun.integration.agentscope.builtin.toolset()to usets.to_agentscope(...)for correct tool conversion.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ) -> List[Any]: | ||
| """将内置工具集封装为 LangChain ``StructuredTool`` 列表。 / AgentScope Built-in Integration Functions""" | ||
|
|
||
| ts = _toolset(input=name, config=config) | ||
| return ts.to_crewai( | ||
| return ts.to_agentscope( |
There was a problem hiding this comment.
The toolset() docstring says it returns a LangChain StructuredTool list, but this AgentScope integration now returns AgentScope-formatted tools (via to_agentscope()), which are not LangChain StructuredTools. Updating the docstring to describe the actual AgentScope return type/usage would avoid misleading users.
| ts = _toolset(input=name, config=config) | ||
| return ts.to_crewai( | ||
| return ts.to_agentscope( | ||
| prefix=prefix, | ||
| modify_tool_name=modify_tool_name, | ||
| filter_tools_by_name=filter_tools_by_name, |
There was a problem hiding this comment.
This bug fix changes the framework conversion method used by the AgentScope toolset() helper. To prevent regressions (e.g., accidentally calling to_crewai() again), please add a unit/integration test that exercises agentrun.integration.agentscope.builtin.toolset() and asserts the returned tools are AgentScope-compatible (not CrewAI/LangChain formatted).
…n toolset()
The toolset() function in agentscope integration was incorrectly calling .to_crewai() instead of .to_agentscope(), returning CrewAI-formatted tools instead of AgentScope-formatted ones.
Change-Id: I41758ca6e22173cfc4cc47fa95713c8fb5d992a7
Co-developed-by: Claude noreply@anthropic.com
Fix bugs
Bug detail
Pull request tasks
Update docs
Reason for update
Pull request tasks
Add contributor
Contributed content
Content detail
Others
Reason for update