chore(workflows): use reusable actions for initialize and update#801
chore(workflows): use reusable actions for initialize and update#801nicomiguelino wants to merge 2 commits into
Conversation
- Replace inline build/deploy steps with Screenly/edge-apps-actions - Drop explicit `build_system` and `deploy_from_dist` inputs (auto-detected) - Pass `path` input pointing to the app subdirectory under edge-apps/ Depends on Screenly/edge-apps-actions#7
PR Reviewer Guide 🔍(Review updated until commit ef5e445)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Pull request overview
This PR refactors the manual Edge App deployment workflows to rely on reusable actions from Screenly/edge-apps-actions, simplifying the workflow inputs and standardizing deploy behavior for the monorepo’s edge-apps/<app_name> layout.
Changes:
- Replaced inline build/deploy logic in the Edge App workflows with
Screenly/edge-apps-actions(initializeandupdate). - Removed
build_systemanddeploy_from_distworkflow inputs in favor of action auto-detection. - Passed an explicit
path: edge-apps/<edge_app_name>to support the monorepo directory structure.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/update-edge-app.yml | Switches Edge App update flow to Screenly/edge-apps-actions/update and removes inline build/deploy steps. |
| .github/workflows/initialize-app.yml | Switches Edge App initialization flow to Screenly/edge-apps-actions/initialize and removes inline create/deploy/instance steps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Pin initialize action from feat/add-path-input to v1 - Pin update action from feat/add-path-input to v1
|
Persistent review updated to latest commit ef5e445 |
PR Code Suggestions ✨No code suggestions found for the PR. |
User description
Summary
initialize-app.ymlandupdate-edge-app.ymlwithScreenly/edge-apps-actionsbuild_systemanddeploy_from_distinputs — the actions auto-detect viapackage.jsonpath: edge-apps/<app_name>to support the monorepo layoutDepends on
Screenly/edge-apps-actions#7 — must be merged and the
v1tag moved before this workflow reference is updated from@feat/add-path-inputto@v1.PR Type
Enhancement
Description
Replace initialization workflow with reusable action
Replace update workflow with reusable action
Pass monorepo
pathand environment inputsPin shared edge-app actions to
v1Diagram Walkthrough
File Walkthrough
initialize-app.yml
Switch initialization to reusable shared action.github/workflows/initialize-app.yml
Screenly/edge-apps-actions/initialize@v1screenly_api_token, app name, title, and environmentpathasedge-apps/${{ inputs.edge_app_name }}update-edge-app.yml
Switch update flow to reusable action.github/workflows/update-edge-app.yml
Screenly/edge-apps-actions/update@v1screenly_api_token,environment, and deletion flagpathfor the target app