Model split fix via java parser#20
Open
gkocak-scottlogic wants to merge 1 commit intomainfrom
Open
Conversation
|
As discussed, I think the plan for this is not to merge, at least for the moment, as it is a short term solution for the problem in ScottLogic/openapi-forge#180. Having many classes in one in ApiModel.java wasn't an issue for the cucumber tests in the end. However, we'll keep this PR for the moment as a point of reference if we do need it, or we need to do something similar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Placeholder PR for model split logic via java parser. Requires changes to be called at
postProcessstage after #14 is merged with java-parser dependency.Edit and clarification:
Initially, this PR has been proposed becuase
ApiModelmodel classes are generated in one single java file and this limits the visibility of the generated model classes to package visible.The way this PR operates is that it uses
java-parserin node space on top of the initially generated code to alter/manipulate the generated model classes.However, after #14 is merged, we#ve come to the conclusion that the class visibility was not an actual immediate issue for the generated code.
So, we don't require the model api classes to be in separate java files with public visibility, at least not yet. However, this procedure might still be necessary for future work to be carried so, the consensus was to leave this work in this PR without merging.