Skip to content

Use the new, official digicert action#3937

Open
rozyczko wants to merge 2 commits intomainfrom
windows_sign_2026
Open

Use the new, official digicert action#3937
rozyczko wants to merge 2 commits intomainfrom
windows_sign_2026

Conversation

@rozyczko
Copy link
Copy Markdown
Member

@rozyczko rozyczko commented May 1, 2026

Description

New windows signing action implemented

Fixes #3925

How Has This Been Tested?

Will be tested with the installer

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • [ X] There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • [ X] There is a chance this will affect the installers, if so
    • [X ] Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)
    • Wheels installer (GH artifact) has been tested (installed and worked)

Licensing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@rozyczko
Copy link
Copy Markdown
Member Author

rozyczko commented May 2, 2026

@rozyczko rozyczko marked this pull request as ready for review May 2, 2026 15:13
Copy link
Copy Markdown
Contributor

@krzywon krzywon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The installer file you linked to was signed and ran as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update windows binary signing action

2 participants