Conversation
It is assumed a few lines down that source is not None
close signal was incorrectly connected to closeEvent method which generated debug tracebacks ERROR sas.qtgui.Perspectives.Fitting.FittingWidget (FittingWidget.py:148) :: TypeError: DocViewWindow.closeEvent() missing 1 required positional argument: 'event'
Render the documentation system inactive rather than crashing when the docs can't be located
…g - use the appropriate lookup method
… to inspect which button was pushed instead of looking at retval
…e entire name and not just part of it to ensure fits aren't matched to datatnames
Switch links to point to github files instead
Icon file contains 1024x1024 PNG but is only a 256x256 icon, so shrink it down to that size and also optimise the PNG compression And yes, there are 4 duplicate copies of the icon in the git repository
…e versions of the same text aren't in the code.
….1.1 release notes
Documentation fixes and v6.1.3-specific changes
…-available-in-batch-fitting point to the correct logic
DrPaulSharp
left a comment
DrPaulSharp
left a comment
There was a problem hiding this comment.
This all looks good to me.
|
I just resolved the merge conflicts. Merge if you think it's ready. |
DrPaulSharp
left a comment
DrPaulSharp
left a comment
There was a problem hiding this comment.
Couple of things to look at here.
There was a problem hiding this comment.
Should this file be included in the repo?
There was a problem hiding this comment.
This file is already in main. I'm not sure what it is for, but that shouldn't stop this PR. I'll run a quick git history to see where it came from.
There was a problem hiding this comment.
This file refers throughout to version 6.1.2. It should presumerably be updated to 6.1.3.
There was a problem hiding this comment.
All of those are mock patched to a specific version. @rozyczko did this as a part of the QTWebEngine removal. I'll make a new branch and change the versions to a real version that has documentation on the web, but old enough no one might confuse this for something that needs updating every release.
9 participants
Description
This has all of the v6.1.3 changes that aren't already in main. Mostly version numbers, release notes, copyright years, and the zenodo DOI, but a couple of other changes.