Avg clean up#203
Conversation
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull request overview
This PR focuses on linting and improving type hints in sasdata/data_util/averaging.py to make ROI averaging utilities easier to maintain and safer for future refactors.
Changes:
- Added
numpy.typingusage and updated ndarray return annotations. - Reformatted several class constructors/calls for readability and consistent typing.
- Tightened
__call__signatures across multiple ROI/averaging helper classes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| super().__init__(r_range=r_range, phi_range=phi_range, center = center) | ||
| super().__init__(r_range=r_range, phi_range=phi_range, center=center) | ||
| print(nbins) |
| return Data1D(x=phi_centers, y=intensity, dy=error) | ||
|
|
||
|
|
||
| ''' | ||
| """ | ||
| # Convert angular data back to the original phi range | ||
| phi_data += phi_offset | ||
| # In the old manipulations.py, we also had this shift to plot the data |
| def __call__(self, data2D: Data2D) -> Data1D: | ||
| """ | ||
| Apply the ring to the data set. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
No quality gates enabled for this code.
See analysis details in CodeScene
Quality Gate Profile: Custom Configuration
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
krzywon
left a comment
krzywon
left a comment
There was a problem hiding this comment.
This all looks reasonable. I would suggest you look at a couple of the Copilot suggestions
Lint and properly type hint
averaging.pyfor future work.