Skip to content

Using native typescript loader#3267

Merged
RobinTail merged 18 commits intomake-v28from
native-ts-execution
Mar 25, 2026
Merged

Using native typescript loader#3267
RobinTail merged 18 commits intomake-v28from
native-ts-execution

Conversation

@RobinTail
Copy link
Copy Markdown
Owner

Using Node.js 22.18 and higher no longer requires unrun to execute typescript.
Though, it requires .ts extensions (#3055) and verbatimModuleSyntax to enforce type-only imports where implied.

@RobinTail RobinTail added this to the v28 milestone Mar 18, 2026
@RobinTail RobinTail added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file CI/CD labels Mar 18, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 18, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 19d21ec7-88ad-4e9d-be8f-ab477e40df11

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch native-ts-execution

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@RobinTail RobinTail changed the title Using native typescript execution and loader instead of unrun. Using native typescript loader Mar 18, 2026
@RobinTail RobinTail marked this pull request as ready for review March 18, 2026 12:32
@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog Bot commented Mar 18, 2026

Review Summary

Reviewed PR #3267: Using native typescript loader

What Changed

  • Added verbatimModuleSyntax: true to tsconfig.json
  • Converted implicit type imports to explicit import type syntax (78 files)
  • Added .ts extensions to relative imports in the example folder
  • Updated Node.js version in CI workflow from 22 to 24

Assessment: LGTM

The implementation is correct:

  • Type imports properly use import type syntax (required by verbatimModuleSyntax)
  • Example code uses .ts extensions for native TypeScript execution
  • Library source code omits extensions (correct for build tooling with noEmit: true)
  • Changes are consistent across the codebase

No actionable issues found.

Pullfrog  | View workflow run | Triggered by Pullfrogpullfrog.com𝕏

Comment thread express-zod-api/src/routing-walker.ts Outdated
@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog Bot commented Mar 18, 2026

Addressed review feedback: Removed the redundant export type { Routing }; re-export from routing-walker.ts. Change pushed and review comment replied to.

Pullfrog  | View workflow run | Triggered by Pullfrogpullfrog.com𝕏

Copy link
Copy Markdown
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

Comment thread express-zod-api/src/documentation.ts Outdated
@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog Bot commented Mar 18, 2026

Fixed the review feedback: Changed the import of Routing in express-zod-api/src/documentation.ts from ./routing-walker to ./routing. The fix has been committed and pushed to the branch.

Pullfrog  | View workflow run | Triggered by Pullfrogpullfrog.com𝕏

@coveralls-official
Copy link
Copy Markdown

coveralls-official Bot commented Mar 21, 2026

Coverage Status

coverage: 100.0%. remained the same
when pulling 3121533 on native-ts-execution
into db876a2 on make-v28.

Copy link
Copy Markdown
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed.
this is fine for now.
later can enforce ts extensions globally by removing root tsconfig module customizations (if needed)

@RobinTail RobinTail merged commit 994d600 into make-v28 Mar 25, 2026
11 checks passed
@RobinTail RobinTail deleted the native-ts-execution branch March 25, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant