Skip to content

[codex] Fix tool contract shapes#854

Merged
RhysSullivan merged 1 commit into
mainfrom
codex/tool-contract-shapes
May 21, 2026
Merged

[codex] Fix tool contract shapes#854
RhysSullivan merged 1 commit into
mainfrom
codex/tool-contract-shapes

Conversation

@RhysSullivan
Copy link
Copy Markdown
Owner

@RhysSullivan RhysSullivan commented May 21, 2026

Summary

  • Add described TypeScript contracts for built-in Executor discovery tools: search, executor.sources.list, and describe.tool.
  • Describe OpenAPI tool success results with the runtime transport envelope: { status, headers, data }.
  • Add regression coverage that type-checks real read-only invocation results against their described output contracts.
  • Update real-spec snapshots for the new OpenAPI envelope shape.
  • Add a patch changeset for the affected release packages.

Root Cause

Built-in discovery tools were routed outside normal registered tool schema lookup, so tools.describe.tool fell back to a minimal stub. OpenAPI tools registered the upstream response body schema, while invocation returns a transport envelope around that body.

Validation

Full local gates passed on the updated branch:

  • bun run format:check
  • bun run lint
  • bun run typecheck
  • bun run test

Targeted checks also passed while developing:

  • bunx vitest run src/tool-invoker.test.ts from packages/core/execution
  • bunx vitest run src/sdk/plugin.test.ts from packages/plugins/openapi
  • bunx vitest run src/sdk/real-specs.test.ts --update from packages/plugins/openapi

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 21, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing c074b12 Commit Preview URL

Branch Preview URL
May 21 2026, 10:21 AM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 21, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud c074b12 May 21 2026, 10:21 AM

@RhysSullivan RhysSullivan force-pushed the codex/tool-contract-shapes branch from 20b573e to c074b12 Compare May 21, 2026 10:20
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 21, 2026

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@854

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@854

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@854

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@854

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@854

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@854

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@854

@executor-js/plugin-google-discovery

npm i https://pkg.pr.new/@executor-js/plugin-google-discovery@854

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@854

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@854

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@854

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@854

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@854

executor

npm i https://pkg.pr.new/executor@854

commit: 20b573e

@RhysSullivan RhysSullivan marked this pull request as ready for review May 21, 2026 10:20
@RhysSullivan RhysSullivan merged commit 1b80186 into main May 21, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant