Skip to content

Let user know when CMAKE_CXX_FLAGS are being ignored.#550

Open
stefanatwork wants to merge 10 commits intomasterfrom
sw/ignore_cxx_flags_message
Open

Let user know when CMAKE_CXX_FLAGS are being ignored.#550
stefanatwork wants to merge 10 commits intomasterfrom
sw/ignore_cxx_flags_message

Conversation

@stefanatwork
Copy link
Copy Markdown
Collaborator

Fixes #513

@stefanatwork stefanatwork requested review from dopitz and svenwoop June 11, 2025 19:57
@stefanatwork stefanatwork force-pushed the sw/ignore_cxx_flags_message branch from 40c4161 to e314eda Compare June 12, 2025 09:43
@stefanatwork stefanatwork requested review from Copilot and removed request for dopitz April 13, 2026 13:38
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses #513 by surfacing a CMake warning when users set CMAKE_CXX_FLAGS but Embree is configured to ignore them via EMBREE_IGNORE_CMAKE_CXX_FLAGS=ON, helping prevent confusing “flags not applied” build behavior.

Changes:

  • Add a MESSAGE(WARNING ...) when CMAKE_CXX_FLAGS is non-empty and EMBREE_IGNORE_CMAKE_CXX_FLAGS is enabled.
  • Apply the warning consistently across the Intel, GNU, Clang, and DPCPP toolchain CMake modules.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
common/cmake/intel.cmake Warn when CMAKE_CXX_FLAGS is about to be cleared due to EMBREE_IGNORE_CMAKE_CXX_FLAGS.
common/cmake/gnu.cmake Same warning for GNU toolchain path before clearing CMAKE_CXX_FLAGS.
common/cmake/dpcpp.cmake Same warning for DPCPP/non-Windows path before clearing CMAKE_CXX_FLAGS.
common/cmake/clang.cmake Same warning for Clang/non-Windows path before clearing CMAKE_CXX_FLAGS.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread common/cmake/intel.cmake Outdated
Comment thread common/cmake/gnu.cmake Outdated
Comment thread common/cmake/dpcpp.cmake Outdated
Comment thread common/cmake/clang.cmake Outdated
stefanatwork and others added 4 commits April 14, 2026 08:17
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warn (or error) when CMAKE_CXX_FLAGS is set and EMBREE_IGNORE_CMAKE_CXX_FLAGS is ON

2 participants