Let user know when CMAKE_CXX_FLAGS are being ignored.#550
Open
stefanatwork wants to merge 10 commits intomasterfrom
Open
Let user know when CMAKE_CXX_FLAGS are being ignored.#550stefanatwork wants to merge 10 commits intomasterfrom
stefanatwork wants to merge 10 commits intomasterfrom
Conversation
40c4161 to
e314eda
Compare
There was a problem hiding this comment.
Pull request overview
This PR addresses #513 by surfacing a CMake warning when users set CMAKE_CXX_FLAGS but Embree is configured to ignore them via EMBREE_IGNORE_CMAKE_CXX_FLAGS=ON, helping prevent confusing “flags not applied” build behavior.
Changes:
- Add a
MESSAGE(WARNING ...)whenCMAKE_CXX_FLAGSis non-empty andEMBREE_IGNORE_CMAKE_CXX_FLAGSis enabled. - Apply the warning consistently across the Intel, GNU, Clang, and DPCPP toolchain CMake modules.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| common/cmake/intel.cmake | Warn when CMAKE_CXX_FLAGS is about to be cleared due to EMBREE_IGNORE_CMAKE_CXX_FLAGS. |
| common/cmake/gnu.cmake | Same warning for GNU toolchain path before clearing CMAKE_CXX_FLAGS. |
| common/cmake/dpcpp.cmake | Same warning for DPCPP/non-Windows path before clearing CMAKE_CXX_FLAGS. |
| common/cmake/clang.cmake | Same warning for Clang/non-Windows path before clearing CMAKE_CXX_FLAGS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #513