Skip to content

Fix #7354, Implementing NSE in cube#7603

Open
sisyphuswastaken wants to merge 16 commits intoRdatatable:masterfrom
sisyphuswastaken:fix-#7354
Open

Fix #7354, Implementing NSE in cube#7603
sisyphuswastaken wants to merge 16 commits intoRdatatable:masterfrom
sisyphuswastaken:fix-#7354

Conversation

@sisyphuswastaken
Copy link
Copy Markdown

@sisyphuswastaken sisyphuswastaken commented Jan 19, 2026

Pertains to issue #7354.
Changes implemented:

  • isolated logic for processing SDcols from the [.data.table function, encapsulated it into a helper function .processSDcols.
  • Added tests for code coverage
  • removed the try-catch error block, to make errors more specific and debugging easier
    This PR continues work from Implementing NSE in cube #7540 and and Implementing NSE in cube #7543.

@sisyphuswastaken sisyphuswastaken changed the title Fix 7354 Fix #7354 Jan 19, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.02%. Comparing base (9a8f664) to head (a8d3875).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7603      +/-   ##
==========================================
- Coverage   99.04%   99.02%   -0.02%     
==========================================
  Files          87       87              
  Lines       17031    17095      +64     
==========================================
+ Hits        16868    16928      +60     
- Misses        163      167       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jangorecki

This comment was marked as resolved.

@sisyphuswastaken sisyphuswastaken changed the title Fix #7354 Fix #7354, Implementing NSE in cube Jan 19, 2026
@sisyphuswastaken

This comment was marked as resolved.

@sisyphuswastaken
Copy link
Copy Markdown
Author

sisyphuswastaken commented Feb 22, 2026

I've added new tests for code coverage, and tried to undo the unnecessary changes that occurred when I had replaced the full function while integrating .processSDcols.

@sisyphuswastaken
Copy link
Copy Markdown
Author

sisyphuswastaken commented Mar 10, 2026

Hello! Bumping on this, let me know if any changes are to be made to the PR, I'd be happy to adjust :) @jangorecki

@sisyphuswastaken
Copy link
Copy Markdown
Author

sisyphuswastaken commented Mar 31, 2026

sorry for the delays, I was swamped with assignments but I'll push changes within this week. Also since I made a new branch, it seems as if some of my changes (the use of the helper function in [.data.table) weren't transferred properly. I'll fix that and have the changes ready for review within this week. I apologize for the inconvenience caused.

sisyphuswastaken added 2 commits April 3, 2026 01:18
Copy link
Copy Markdown
Author

@sisyphuswastaken sisyphuswastaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've included the helper in [.data.table and added tests. Some might seem redundant since I added them for code coverage, which I'm still working on. I'm not yet sure how to tackle the project’s coverage checks failing, but I'm actively working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants