[AIMIGRAPHX-1050] Enable MLIR Attention by Default on MI350#4901
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables rocMLIR attention by default on additional GPU architectures (MI350-class) by expanding the set of supported gfx prefixes used to auto-enable MLIR attention.
Changes:
- Extend the default-enable check for MLIR attention from
gfx94*to bothgfx94*andgfx95*devices. - Refactor the device-prefix logic to use a small prefix list and
std::any_of.
kahmed10
approved these changes
May 21, 2026
TedThemistokleous
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
rocMLIR attention is currently only default for gfx94x (MI300). We can probably enable this for MI350 as well.
Technical Details
Adds a list of gfx prefixes that will use MLIR attention by default.
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot Applicable