feat: expose subscriptions limited availability#841
Draft
raluik wants to merge 11 commits into
Draft
Conversation
raluik
commented
May 14, 2026
| {}; | ||
| private readonly messageSubscribers = new Map< | ||
| string, | ||
| Subscriber<Record<string, any>> |
Contributor
Author
There was a problem hiding this comment.
Subscriber taken from new Observer constructor definition.
raluik
commented
May 14, 2026
| if (query.kind === 'Document') { | ||
| return print(query); | ||
| } | ||
| throw new Error('queryToString: query must be a string or a DocumentNode'); |
Contributor
Author
There was a problem hiding this comment.
The previous checks were exhaustive.
raluik
commented
May 14, 2026
| shareReplay(1), | ||
| ); | ||
|
|
||
| this.erroredSubscriptionsMessageIds$.subscribe(); |
Contributor
Author
There was a problem hiding this comment.
To turn the observable hot just in case if no consumer decides to subscribe to it. Otherwise later on if they decide to do so, they wouldn't know if any subscriptions may have errored.
raluik
commented
May 14, 2026
| return () => this.stopSubscription(id); | ||
| this.sendMessage(messageId, MessageType.GQL_START, { query }).catch( | ||
| (error: Error) => { | ||
| this.logger.error('Failed to start subscription: ', error); |
Contributor
Author
There was a problem hiding this comment.
Before rejected promises were unhandled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's consumers handle state where some subscriptions fail.
Checklist