Skip to content

Fix log access for target_key in sweep.py#558

Open
ClashLuke wants to merge 1 commit into
PufferAI:4.0from
ClashLuke:patch-3
Open

Fix log access for target_key in sweep.py#558
ClashLuke wants to merge 1 commit into
PufferAI:4.0from
ClashLuke:patch-3

Conversation

@ClashLuke
Copy link
Copy Markdown

if cost > 1.2 * self.upper_cost_threshold:
    return 0.9 * self.max_score

This check doesn't work if the numbers have a nonzero offset, as the offset is scaled as well. Most visually, if I have a negative score, it will push the target up toward zero, instead of down into an easier regime.

The intended code is likely closer to max_score - 0.1 * (max_score - min_score)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant