Fix overlay layers not working properly#880
Merged
JeroenDeDauw merged 2 commits intomasterfrom Apr 5, 2026
Merged
Conversation
JeroenDeDauw
force-pushed
the
fix/overlay-layers-not-working
branch
2 times, most recently
from
ccc030f to
a176f6d
Compare
Fixes #642 In `addLayersAndOverlays()`, the layer control was initialized with an empty array `[]` for base layers, then base layers were added individually via `control.addBaseLayer()`. This caused overlays to not layer correctly. Pass base layers as a proper object to `L.control.layers()` directly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Verifies that addLayersAndOverlays passes a proper object (not an empty array) as base layers to L.control.layers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
JeroenDeDauw
force-pushed
the
fix/overlay-layers-not-working
branch
from
a176f6d to
0913337
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #642
In
addLayersAndOverlays(), the layer control was initialized with an emptyarray
[]for base layers, then base layers were added individually viacontrol.addBaseLayer(). This caused overlays to not layer correctly.Pass base layers as a proper object to
L.control.layers()directly.