Fix MapSaver.save() swallowing API errors#877
Merged
JeroenDeDauw merged 2 commits intomasterfrom Apr 5, 2026
Merged
Conversation
Fixes #870 The `.then(paremeters.done)` call had no `.catch()` handler. On API failure, the save button disappears, no error is shown, and changes are trapped. Add error handler that alerts the user about the failure. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
JeroenDeDauw
force-pushed
the
fix/map-saver-error-handling
branch
3 times, most recently
from
f41d774 to
7635b56
Compare
Verifies that when mw.Api().edit() fails, the onError callback is called instead of silently swallowing the error. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
JeroenDeDauw
force-pushed
the
fix/map-saver-error-handling
branch
from
7635b56 to
d4357dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #870
The
.then(paremeters.done)call had no.catch()handler. On API failure,the save button disappears, no error is shown, and changes are trapped.
Add error handler that alerts the user about the failure.