Bump zlib#849
Open
tgauth wants to merge 3 commits into
Open
Conversation
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Updates the Win32 OpenSSH vcpkg manifest and Visual Studio project link settings to use zlib 1.3.2 and accommodate the zlib library filename change (from zlib.lib to zs.lib/zsd.lib) via a centralized MSBuild property.
Changes:
- Bump vcpkg override for
zlibfrom1.3.1to1.3.2. - Replace hard-coded
zlib.libreferences in multiple.vcxprojfiles with$(ZLibName). - Define
$(ZLibName)inpaths.targetsfor Debug vs non-Debug configurations.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| contrib/win32/openssh/vcpkg.json | Bumps the vcpkg zlib override to 1.3.2. |
| contrib/win32/openssh/paths.targets | Adds ZLibName property mapping Debug/non-Debug to zsd.lib/zs.lib. |
| contrib/win32/openssh/unittest-kex.vcxproj | Uses $(ZLibName) instead of zlib.lib in linker inputs. |
| contrib/win32/openssh/sshd.vcxproj | Uses $(ZLibName) instead of zlib.lib in linker inputs. |
| contrib/win32/openssh/sshd-session.vcxproj | Uses $(ZLibName) instead of zlib.lib in linker inputs. |
| contrib/win32/openssh/sshd-auth.vcxproj | Uses $(ZLibName) instead of zlib.lib in linker inputs. |
| contrib/win32/openssh/ssh.vcxproj | Uses $(ZLibName) instead of zlib.lib in linker inputs. |
| contrib/win32/openssh/ssh-sk-helper.vcxproj | Uses $(ZLibName) instead of zlib.lib in linker inputs. |
| contrib/win32/openssh/ssh-pkcs11-helper.vcxproj | Uses $(ZLibName) instead of zlib.lib in linker inputs. |
| contrib/win32/openssh/ssh-keyscan.vcxproj | Uses $(ZLibName) instead of zlib.lib in linker inputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary