Add all game corner encounters

[notblisy]

The goal of this PR is to add every single game corner encounter from gen 1-4. After that, the game and prize corner kind of got removed.

To add these encounters I sourced from two bulbapedia articles:

• Celadon Game Corner
• Goldenrod Gamecorner

I had to add two new location-areas:

• Celadon Prize Corner (the building to the right of the game corner)
• Goldenrod Game Corner (goldenrod has no prize corner)

I also added a new encounter condition called coins:

• 16,coins

This is to denote how many coins a specific Pokemon costs. An example of this would be, for Abra in blue:

• 115,16,coins-180,1

This is 58 total encounters and should cover everything. I marked them all as "gift" encounter methods. I think I got all the relevant prose.

This encompasses the following games:

• RBY
• GSC
• FRLG
• HGSS

I don't believe any other game has prizes that're pokemon.

[notblisy]

As a note: I mostly put this up so it could be reviewed. Changing the encounters + locations to follow up the gen 6 mirage island stuff is no big deal thanks to my new workflow where I don't change everything manually.

[jemarq04]

I double-checked some things with the Bulbapedia links you provided and added minor corrections.

In addition, could you fill in encounter information for versions red-jpn and green-jpn? They are recent additions but I'd like for them to be up-to-date too. Looks like Bulbapedia has the information so that should be helpful.

Lastly, looks like you missed encounter_condition_prose.csv!

[jemarq04]

I'm also wondering if we wanted to create a new encounter method here such as purchase? Maybe that would make it clearer that the encounter conditions here are consumed to trigger the encounter, rather than just a threshold so that we can encounter them? This may be pedantic, so what do you think @Naramsim ? The encounter method of gift with the condition of coins-100 reads to me like once you get 100 coins you receive a gift for example.

[Naramsim]

Hi regarding costs and a new purchase method, this PR as well is dealing with costs: #1431 Maybe you can find something useful.

By coins you mean pokedollars or the standard pokemon currency? As Items do, I guess Pokemon as well can be purchased not only by spending coins but maybe using other currencies?

[jemarq04]

I don't remember how often Pokemon can be purchased like this, but these use the game corner "Coins". I think adding some sort of pricing like the other PR may be more work than necessary for an encounter condition I think.

[notblisy]

I don't remember how often Pokemon can be purchased like this, but these use the game corner "Coins". I think adding some sort of pricing like the other PR may be more work than necessary for an encounter condition I think.

Every single encounter should be documented in this PR. They're really only purchasable in Kanto/Johto games. The only other purchasable pokemon I can even think of is Magikarp in RBY/FRLG in the Pokecenter before Mt. Moon, which is like 500 Pokedollars and not the same thing as this.

Hi regarding costs and a new purchase method, this PR as well is dealing with costs: #1431 Maybe you can find something useful.

By coins you mean pokedollars or the standard pokemon currency? As Items do, I guess Pokemon as well can be purchased not only by spending coins but maybe using other currencies?

The gamecorner has its own currency called coins. Coins are purchasable with Pokedollars or winnable via gambling at the gamecorner.

Items can be purchased at the game corner with coins, but imo this is out of scope for this PR. Personally I think an encounter condition is fine.

A new encounter method could work. I don't feel too strongly about it one way or the other, so I'll default to @jemarq04

[notblisy]

I double-checked some things with the Bulbapedia links you provided and added minor corrections.

In addition, could you fill in encounter information for versions red-jpn and green-jpn? They are recent additions but I'd like for them to be up-to-date too. Looks like Bulbapedia has the information so that should be helpful.

Lastly, looks like you missed encounter_condition_prose.csv!

Added red, green, and blue japan to this. I didn't include them initially because I don't really know a lot about those games, especially jpn blue.

[jemarq04]

A new encounter method could work. I don't feel too strongly about it one way or the other, so I'll default to @jemarq04

Thinking about it further, let’s leave it as gift. The encounter condition prose is descriptive. I’ll redo the review soon.

[notblisy]

Sorry I never do the ones you tag-- it's not me trying to take credit for all the commits, it's just whenever I click the commit button thru github it doesn't work.

[jemarq04]

Sorry I never do the ones you tag-- it's not me trying to take credit for all the commits, it's just whenever I click the commit button thru github it doesn't work.

No worries! Github is pretty annoying when it comes to certain things for me as well. It never lets me resolve threads for example lol

[jemarq04]

All looks great – thanks! As you suggested, we can wait until #1447 is merged (unless @ItsMeJoji would rather take some more time before then).

[Naramsim]

I think we can merge this, @ItsMeJoji's PR already has some conflicts so those need to be addressed. Here I don't see any so I'm merging.

[pokeapi-machine-user]

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

[pokeapi-machine-user]

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

[anhthang]

The gamecorner has its own currency called coins. Coins are purchasable with Pokedollars or winnable via gambling at the gamecorner.

According to the describe from Bulbapedia, I think the "coin" in my PR is what you need

Coins are utilized to play the various games of the Game Corners throughout the Pokémon world as well as to obtain and collect the various Game Corner prizes available. Coins can be bought at the price of $20 per Coin.