feat: Implement local bookmarking and save button#293
Open
d3f4ultt wants to merge 1 commit intoPocket:masterfrom
Open
feat: Implement local bookmarking and save button#293d3f4ultt wants to merge 1 commit intoPocket:masterfrom
d3f4ultt wants to merge 1 commit intoPocket:masterfrom
Conversation
- Adds core logic for saving and retrieving bookmarks by domain using chrome.storage.local (src/common/bookmarks.js). - Includes unit tests for bookmarking functions (src/common/bookmarks.test.js). Note: 4 tests fail due to a jest-chrome specific issue with `lastError` state persisting between tests. - Injects a floating "Save to MyBookmarks" button into all pages via a new content script (src/pages/bookmark/button.js). - Registers the new content script in manifest.json. - Fixes initial "jest: not found" error by ensuring dependencies are installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lastErrorstate persisting between tests.Goal
Insert purpose of pull request
Todos:
Implementation Decisions
All Submissions: