Closed
Conversation
Ref::Util is_hashref will tell you if the base variable is a hashref, even if its blessed. We should be leaving the internals of blessed objects alone.
The tests for json serialisation are comparing strings; they need a consistent format, canonical for sorted keys (otherwise hash key randomization will cause failures), and pretty (for our viewing pleasure).
Contributor
|
Fixes the same issue for me. |
xsawyerx
approved these changes
Mar 30, 2026
Member
|
@veryrusty++ ! |
Contributor
|
Merged, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for JSON serializer
_ensure_characters:The test suite will likely fail due to hash randomization with this applied, so require sorted keys (canonical representation) in encoded json (string) comparisons.