Default staged skills to their maximum stages#9728
Open
OursCodeur wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
Default staged skills to their maximum stages#9728OursCodeur wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
OursCodeur wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: requested feature backlog - Max stages of skills by default.
Description of the problem being solved:
Stage-based skills default to 1 stage unless the user changes them manually. This makes staged skills show a lower-than-expected default state in both the Skills UI and calculations.
This change stores each active skill's resolved maximum stage count and uses that as the default when no explicit stage count has been set.
Note: this applies when the skill is usable. Skills that are currently unusable because of weapon requirements still behave as they do today until a valid weapon is equipped.
Steps taken to verify a working solution:
Implementation TLDR
While querying the skill details to set the
multiStageflag, the max stage value is now parsed and stored in a newstagesMaxskillData variable and used in the UI where relevant.Skills UI
Calcs Tab
Behaviour without / with usable weapon