Fix variant text ordering for The Adorned and Yoke of Suffering#1783
Merged
Wires77 merged 2 commits intoPathOfBuildingCommunity:devfrom Mar 26, 2026
Merged
Conversation
Multi-line mod continuation lines were interleaved between variants, causing duplicate/missing lines in the variant display. Group each variant's continuation lines together with their first line. Fixes PathOfBuildingCommunity#1774
Blitz54
previously requested changes
Mar 25, 2026
Contributor
Blitz54
left a comment
Blitz54
left a comment
There was a problem hiding this comment.
These changes will be overwritten any time we run the exporter. The proper way to fix this is in the uModsToText script. When I looked at it last, the issue is it sorts mod lines by the stat order, but for multiline mods on variants, we need to keep them bundled together.
Member
|
Blitz is right, but thanks for calling this out. I updated the script in your PR to properly do this for all uniques, even ones we don't parse properly. |
Wires77
approved these changes
Mar 26, 2026
Contributor
Author
|
Sorry, that was my first open source pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-line mod continuation lines were interleaved between variants, causing duplicate/missing lines in the variant display. Group each variant's continuation lines together with their first line.
Fixes #1774
Fixes # .
Description of the problem being solved:
The Adorned and Yoke of Suffering have multi-line mods where the continuation lines were interleaved between variants instead of grouped with their respective variant. This caused duplicate lines to appear for one variant and missing lines for the other in the item display.
Steps taken to verify a working solution:
Before screenshot:
After screenshot: