Azure Functions docs#8237
Draft
mattmercurio wants to merge 21 commits into
Draft
Conversation
mattmercurio
force-pushed
the
azure-functions
branch
2 times, most recently
from
004f58a to
0e65bc1
Compare
* Convention-based handlers * Apply suggestions from code review Co-authored-by: Daniel Marbach <daniel.marbach@openplace.net> Co-authored-by: Andreas Öhlund <andreas.ohlund@particular.net> * Make a TLDR snippet * Whoopsie --------- Co-authored-by: Daniel Marbach <daniel.marbach@openplace.net> Co-authored-by: Andreas Öhlund <andreas.ohlund@particular.net>
* Registration page first version while keeping some redundancy * Fix missing index problem * Better page split and wording tweaks * Refactor handler registration example in documentation Updated the registration code example to reflect new API usage. * Small tweaks * Fix version boundary to use integer majors * Apply suggestions from code review Co-authored-by: Andreas Öhlund <andreas.ohlund@particular.net> * Switch order * Better documentation around the conventions * Explain better the conventions --------- Co-authored-by: Daniel Marbach <danielmarbach@users.noreply.github.com> Co-authored-by: Andreas Öhlund <andreas.ohlund@particular.net>
* 2 projects needed a Core reference * Change affected samples to Core 10 alphas * Easy NSB.Extensions.Hosting removals * Rest of NSB.Extensions.Hosting * Delete "Passing user identity between endpoints using a custom header" sample that uses mutators * Remove "Startup and Shutdown Sequence" sample * Fix deprecated APIs in 4 samples * Updated more samples * Bunch more samples * Fix bad cancellation token usage * Couple more * Need to review this Kafka-Functions sample separately * Kinda big SqlP sample * Bunch more * Version-scope the externally managed mode sample and add a warning * Remaining samples * Fix links and related * Another fix
mattmercurio
force-pushed
the
azure-functions
branch
from
e9334b5 to
0bbaae0
Compare
Member
andreasohlund
left a comment
andreasohlund
left a comment
There was a problem hiding this comment.
Did a first shallow pass
|
|
||
| An endpoint is a partial class composed of three parts: | ||
|
|
||
| - The class is decorated with `[NServiceBusFunction]`. |
Member
There was a problem hiding this comment.
It can be on the trigger method as well so we need to decide which approach to lead with
|
|
||
| NServiceBus log output is forwarded to the Azure Functions logging pipeline automatically. Configure log levels and providers through the standard Functions logging configuration; no additional NServiceBus log setup is required. | ||
|
|
||
| Startup diagnostics are written when the host starts. In Azure they appear in the Functions host log stream and in any configured destination such as Application Insights. |
Member
There was a problem hiding this comment.
The default behavior is a no-op; writing to the log can be opted into via the new API @danielmarbach added in v10.2. Not sure if we have documented that yet?
| { | ||
| [Function(nameof(Orders))] | ||
| public partial Task Orders( | ||
| [ServiceBusTrigger("orders", Connection = "ServiceBusConnection", AutoCompleteMessages = false)] |
Member
There was a problem hiding this comment.
Since the default is AzureWebJobsServiceBus, I wonder if this can be leading users to use this one instead and get tripped up? (ie should we omit it since this shows basic usage)
| { | ||
| var transport = new AzureServiceBusServerlessTransport(TopicTopology.Default) | ||
| { | ||
| ConnectionName = "ServiceBusConnection" |
Member
There was a problem hiding this comment.
Same as above, should we go with the default or not set this as all?
mattmercurio
force-pushed
the
azure-functions
branch
2 times, most recently
from
56fc1c8 to
2c3ae96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.